test: refactor header inclusion to speed up building (for test/mocks/upstream:upstream_mocks) #12407
Merged
mattklein123 merged 20 commits intoenvoyproxy:masterfrom Aug 22, 2020
Merged
Conversation
Signed-off-by: Muge Chen <mugechen@google.com>
Signed-off-by: Muge Chen <mugechen@google.com>
Signed-off-by: Muge Chen <mugechen@google.com>
Signed-off-by: Muge Chen <mugechen@google.com>
Signed-off-by: Muge Chen <mugechen@google.com>
foreseeable
requested review from
PiotrSikora,
alyssawilk,
dio,
lizan,
mattklein123,
snowp and
zuercher
as code owners
Signed-off-by: Muge Chen <mugechen@google.com>
asraa
reviewed
Aug 3, 2020
Contributor
asraa
left a comment
asraa
left a comment
There was a problem hiding this comment.
Thank you!!! Seeing some of the mock dependencies completely removed makes me so happy :)
Signed-off-by: Muge Chen <mugechen@google.com>
Signed-off-by: Muge Chen <mugechen@google.com>
Signed-off-by: Muge Chen <mugechen@google.com>
Signed-off-by: Muge Chen <mugechen@google.com>
Contributor
Author
|
Hi @asraa can you have a look at this PR? I have removed unused includes since last time |
ahedberg
previously approved these changes
Aug 14, 2020
Contributor
ahedberg
left a comment
ahedberg
left a comment
There was a problem hiding this comment.
This should've been split into smaller PRs, FWIW. If it's too hard to merge as-is, we may still need to do that.
asraa
reviewed
Aug 20, 2020
asraa
reviewed
Aug 20, 2020
asraa
reviewed
Aug 20, 2020
asraa
reviewed
Aug 20, 2020
asraa
reviewed
Aug 20, 2020
asraa
reviewed
Aug 20, 2020
asraa
reviewed
Aug 20, 2020
asraa
reviewed
Aug 20, 2020
asraa
reviewed
Aug 20, 2020
asraa
reviewed
Aug 20, 2020
asraa
reviewed
Aug 20, 2020
asraa
reviewed
Aug 20, 2020
asraa
reviewed
Aug 20, 2020
asraa
reviewed
Aug 20, 2020
asraa
reviewed
Aug 20, 2020
asraa
reviewed
Aug 20, 2020
asraa
reviewed
Aug 20, 2020
asraa
reviewed
Aug 20, 2020
asraa
reviewed
Aug 20, 2020
asraa
reviewed
Aug 20, 2020
Signed-off-by: Muge Chen <mugechen@google.com>
Signed-off-by: Muge Chen <mugechen@google.com>
Signed-off-by: Muge Chen <mugechen@google.com>
Signed-off-by: Muge Chen <mugechen@google.com>
lavignes
added a commit
to lavignes/envoy
that referenced
this pull request
Aug 24, 2020
* envoy/master: (90 commits) cleanup: use structured binding (envoyproxy#12791) docs: fix header name for retries in gRPC services (envoyproxy#12790) docs: clarify meaning of HeaderValueOption.append (envoyproxy#12792) doc: clarify handling of duplicate xDS resource names (envoyproxy#12756) Dependencies: build updates. (envoyproxy#12786) Ratelimit: Add optional descriptor key to generic_key action (envoyproxy#12734) test: refactor header inclusion to speed up building (for test/mocks/upstream:upstream_mocks) (envoyproxy#12407) docs: Fix omitted word (envoyproxy#12782) ci: avoid uploading dwp as separate artifact (envoyproxy#12777) doc: Fix small typos (envoyproxy#12769) fix cache factory category (envoyproxy#12765) docs: fix typo v1.15.0.rst (envoyproxy#12680) Add clang-cl RBE toolchain for Windows (envoyproxy#12776) fuzz: add router fuzz proto (envoyproxy#12727) header: New HeaderMatcher and StringMatcher type - Contains (envoyproxy#12623) tcp_proxy: use dynamicMetadata() from StreamInfo for load balancing (envoyproxy#12595) network: add io handle recv function for http inspector (envoyproxy#12736) jwt_authn: supports jwt payload without "iss" field (envoyproxy#12744) Add support for nested JSON format in json logging mode (envoyproxy#12602) http: fixing a fuzz flake by setting details on connection teardown (envoyproxy#12737) ... Signed-off-by: Scott LaVigne <lavignes@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the follow up PR for dividing the monolithic mock header
test/mocks/upstream/mocks.h#12048We refactored mock class include directives, this will reduce the target size and building time.
Commit Message: refactor header inclusion to speed up building (for test/mocks/upstream:upstream_mocks)
Risk Level: low
Testing: existing tests
Docs Changes: N/A
Release Notes: no
Related Issues: #10917