Skip to content

test: fixing a race in cx_limit_integration_test#12233

Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
alyssawilk:cx
Jul 22, 2020
Merged

test: fixing a race in cx_limit_integration_test#12233
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
alyssawilk:cx

Conversation

@alyssawilk
Copy link
Contributor

Fixing a race where the TCP session closed the sockets before the accept counter was updated, and the next connect failed.

Risk Level: n/a (test only)
Testing: yes
Docs Changes: no
Release Notes: no
Hopefully fixes #11841

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lizan
Copy link
Member

lizan commented Jul 22, 2020

/backport review

This has been source of stable release CI flakes cc @lambdai

@repokitteh-read-only repokitteh-read-only bot added the backport/review Request to backport to stable releases label Jul 22, 2020
@mattklein123
Copy link
Member

Failed due to a different flake. Will force merge.

@mattklein123 mattklein123 merged commit 9a4980c into envoyproxy:master Jul 22, 2020
KBaichoo pushed a commit to KBaichoo/envoy that referenced this pull request Jul 30, 2020
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
@lambdai lambdai added backport/approved Approved backports to stable releases and removed backport/review Request to backport to stable releases labels Jul 31, 2020
chaoqin-li1123 pushed a commit to chaoqin-li1123/envoy that referenced this pull request Aug 7, 2020
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: chaoqinli <chaoqinli@google.com>
lizan pushed a commit to lizan/envoy that referenced this pull request Nov 11, 2020
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
lizan added a commit to lizan/envoy that referenced this pull request Nov 12, 2020
@alyssawilk alyssawilk deleted the cx branch December 10, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/approved Approved backports to stable releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cx_limit_integration_test flakes

4 participants