tcp: switching to the new pool by default#12180
Merged
alyssawilk merged 1 commit intoenvoyproxy:masterfrom Jul 20, 2020
Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
zuercher
approved these changes
Jul 20, 2020
Member
zuercher
left a comment
zuercher
left a comment
There was a problem hiding this comment.
Do we know if anyone's run Envoy in prod with the flag turned on?
Contributor
Author
|
Not that I know of, but I defaulted it off because of proximity to the release rather than smoke testing. |
ggreenway
added a commit
to ggreenway/envoy
that referenced
this pull request
Jul 20, 2020
This reverts commit f50fba1. Signed-off-by: Greg Greenway <ggreenway@apple.com>
mattklein123
pushed a commit
that referenced
this pull request
Jul 21, 2020
KBaichoo
pushed a commit
to KBaichoo/envoy
that referenced
this pull request
Jul 30, 2020
Risk Level: High (roll back first, ask questions later) Testing: cloned all unit tests and all integration tests. Docs Changes: n/a Release Notes: inline Runtime guard: envoy.reloadable_features.new_tcp_connection_pool Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
scheler
pushed a commit
to scheler/envoy
that referenced
this pull request
Aug 4, 2020
Risk Level: High (roll back first, ask questions later) Testing: cloned all unit tests and all integration tests. Docs Changes: n/a Release Notes: inline Runtime guard: envoy.reloadable_features.new_tcp_connection_pool Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: scheler <santosh.cheler@appdynamics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk Level: High (roll back first, ask questions later)
Testing: cloned all unit tests and all integration tests.
Docs Changes: n/a
Release Notes: inline
Runtime guard: envoy.reloadable_features.new_tcp_connection_pool