Skip to content

tls: improve ssl socket test coverage #12177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lizan merged 1 commit into from
Jul 20, 2020
Merged

tls: improve ssl socket test coverage #12177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions test/extensions/transport_sockets/tls/ssl_socket_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,8 +345,13 @@ void testUtil(const TestUtilOptions& options) {
EXPECT_EQ(options.expectedDigest(),
server_connection->ssl()->sha256PeerCertificateDigest());
}
// Assert twice to ensure a cached value is returned and still valid.
EXPECT_EQ(options.expectedClientCertUri(), server_connection->ssl()->uriSanPeerCertificate());
EXPECT_EQ(options.expectedClientCertUri(), server_connection->ssl()->uriSanPeerCertificate());

if (!options.expectedLocalUri().empty()) {
// Assert twice to ensure a cached value is returned and still valid.
EXPECT_EQ(options.expectedLocalUri(), server_connection->ssl()->uriSanLocalCertificate());
EXPECT_EQ(options.expectedLocalUri(), server_connection->ssl()->uriSanLocalCertificate());
}
EXPECT_EQ(options.expectedSerialNumber(),
Expand Down Expand Up @@ -653,6 +658,8 @@ const std::string testUtilV2(const TestUtilOptionsV2& options) {
dynamic_cast<const SslSocketInfo*>(client_connection->ssl().get());
SSL* client_ssl_socket = ssl_socket->ssl();
if (!options.expectedProtocolVersion().empty()) {
// Assert twice to ensure a cached value is returned and still valid.
EXPECT_EQ(options.expectedProtocolVersion(), client_connection->ssl()->tlsVersion());
EXPECT_EQ(options.expectedProtocolVersion(), client_connection->ssl()->tlsVersion());
}
if (!options.expectedCiphersuite().empty()) {
Expand Down