Skip to content

format: add api-shadow starlark files checker#12147

Merged
htuch merged 2 commits intoenvoyproxy:masterfrom
Shikugawa:check-apishadow-format
Jul 17, 2020
Merged

format: add api-shadow starlark files checker#12147
htuch merged 2 commits intoenvoyproxy:masterfrom
Shikugawa:check-apishadow-format

Conversation

@Shikugawa
Copy link
Member

Signed-off-by: Shikugawa rei@tetrate.io

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Commit Message: #12129 (review), to ensure the consistency between api/bazel/*.bzl and generated_api_shadow/bazel/*.bzl
Additional Description:
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]

Signed-off-by: Shikugawa <rei@tetrate.io>
@Shikugawa
Copy link
Member Author

/assign @htuch

Signed-off-by: Shikugawa <rei@tetrate.io>
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit 5d8588a into envoyproxy:master Jul 17, 2020
KBaichoo pushed a commit to KBaichoo/envoy that referenced this pull request Jul 30, 2020
envoyproxy#12129 (review), to ensure the consistency between api/bazel/*.bzl and generated_api_shadow/bazel/*.bzl

Risk Level: Low

Signed-off-by: Shikugawa <rei@tetrate.io>
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
scheler pushed a commit to scheler/envoy that referenced this pull request Aug 4, 2020
envoyproxy#12129 (review), to ensure the consistency between api/bazel/*.bzl and generated_api_shadow/bazel/*.bzl

Risk Level: Low

Signed-off-by: Shikugawa <rei@tetrate.io>
Signed-off-by: scheler <santosh.cheler@appdynamics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants