linter: Remove diff checker for legacy and new codec sources#12144
Closed
yanavlasov wants to merge 1 commit intoenvoyproxy:masterfrom
Closed
linter: Remove diff checker for legacy and new codec sources#12144yanavlasov wants to merge 1 commit intoenvoyproxy:masterfrom
yanavlasov wants to merge 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Yan Avlasov <yavlasov@google.com>
dmitri-d
approved these changes
Jul 17, 2020
asraa
approved these changes
Jul 17, 2020
Contributor
Author
|
Obsoleted by PR #12149 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Remove diff checker for legacy and new codec sources. Any functional changes to codecs should have corresponding unit tests, and since the same unit test tests both implementations, any functional differences should be detected by the test.
Risk Level: Low
Testing: Run check_format
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Yan Avlasov yavlasov@google.com