test: Remove unit test parameterization for the TapMatcherGenericBodyConfigTest#12143
Merged
junr03 merged 2 commits intoenvoyproxy:masterfrom Jul 17, 2020
Merged
test: Remove unit test parameterization for the TapMatcherGenericBodyConfigTest#12143junr03 merged 2 commits intoenvoyproxy:masterfrom
junr03 merged 2 commits intoenvoyproxy:masterfrom
Conversation
…Test suite Signed-off-by: Yan Avlasov <yavlasov@google.com>
Signed-off-by: Yan Avlasov <yavlasov@google.com>
junr03
approved these changes
Jul 17, 2020
KBaichoo
pushed a commit
to KBaichoo/envoy
that referenced
this pull request
Jul 30, 2020
…Test suite (envoyproxy#12143) Remove unit test parameterization for the TapMatcherGenericBodyConfigTest suite. It does not actually use test parameters. Risk Level: Low, test only Testing: Unit Tests Docs Changes: N/A Release Notes: N/A Signed-off-by: Yan Avlasov <yavlasov@google.com> Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
scheler
pushed a commit
to scheler/envoy
that referenced
this pull request
Aug 4, 2020
…Test suite (envoyproxy#12143) Remove unit test parameterization for the TapMatcherGenericBodyConfigTest suite. It does not actually use test parameters. Risk Level: Low, test only Testing: Unit Tests Docs Changes: N/A Release Notes: N/A Signed-off-by: Yan Avlasov <yavlasov@google.com> Signed-off-by: scheler <santosh.cheler@appdynamics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Remove unit test parameterization for the TapMatcherGenericBodyConfigTest suite. It does not actually use test parameters.
Additional Description:
When we upgrade to the next version of the gtest these types of unit test misconfiguration are going to cause failures. Presently defining test suite as parameterized but using TEST_F instead of TEST_P to define tests causes the tests to not be run at all without any indication.
Risk Level: Low, test only
Testing: Unit Tests
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Yan Avlasov yavlasov@google.com