Change HdsCluster::cluster_ to a value instead of reference#12137
Merged
snowp merged 1 commit intoenvoyproxy:masterfrom Jul 20, 2020
Merged
Change HdsCluster::cluster_ to a value instead of reference#12137snowp merged 1 commit intoenvoyproxy:masterfrom
snowp merged 1 commit intoenvoyproxy:masterfrom
Conversation
Contributor
Author
|
/retest |
|
🤷♀️ nothing to rebuild. |
snowp
suggested changes
Jul 17, 2020
Contributor
snowp
left a comment
snowp
left a comment
There was a problem hiding this comment.
Thanks, just one question on the approach
Signed-off-by: Xiaodong Zhai <xdzhai@google.com>
xdzhai
changed the title
KBaichoo
pushed a commit
to KBaichoo/envoy
that referenced
this pull request
Jul 30, 2020
…oyproxy#12137) Signed-off-by: Xiaodong Zhai <xdzhai@google.com> Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
scheler
pushed a commit
to scheler/envoy
that referenced
this pull request
Aug 4, 2020
…oyproxy#12137) Signed-off-by: Xiaodong Zhai <xdzhai@google.com> Signed-off-by: scheler <santosh.cheler@appdynamics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Change HdsCluster to store Cluster config proto with unique_ptr
Additional Description:
Currently it's created locally and assigned to a const reference, may be better to use unique_ptr .
Risk Level: Low
Testing: Passed hds_test and hds_integration_test.
Docs Changes: N/A
Release Notes: N/A