build: update bazel to 3.4.1#12123
Merged
htuch merged 4 commits intoenvoyproxy:masterfrom Jul 20, 2020
Merged
Conversation
Signed-off-by: Michael Rebello <me@michaelrebello.com>
htuch
reviewed
Jul 17, 2020
htuch
previously approved these changes
Jul 17, 2020
Member
|
The Windows failure looks legit. @wrowe @sunjayBhatia thoughts? |
Member
|
@htuch envoy-build-tools would need to have a toolchain generated and committed for bazel 3.4.x and then that dependency bumped in envoy, we can’t do docker in docker on windows so generating a toolchain on the fly doesn’t work |
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Contributor
Author
|
Updating there: envoyproxy/envoy-build-tools#85 |
lizan
pushed a commit
to envoyproxy/envoy-build-tools
that referenced
this pull request
Jul 18, 2020
Note that Bazel's toolchain for 3.4.1 is tagged 3.4.0: https://github.com/bazelbuild/bazel-toolchains/releases/tag/3.4.0 Unblocking envoyproxy/envoy#12123 Signed-off-by: Michael Rebello <me@michaelrebello.com>
htuch
pushed a commit
to envoyproxy/envoy-build-tools
that referenced
this pull request
Jul 18, 2020
[skip ci] update bazel to 3.4.1 (#85) Note that Bazel's toolchain for 3.4.1 is tagged 3.4.0: https://github.com/bazelbuild/bazel-toolchains/releases/tag/3.4.0 Unblocking envoyproxy/envoy#12123 Signed-off-by: Michael Rebello <me@michaelrebello.com>
htuch
pushed a commit
to envoyproxy/envoy-build-tools
that referenced
this pull request
Jul 18, 2020
[skip ci] Regenerate linux toolchains from 14c1072 [skip ci] update bazel to 3.4.1 (#85) Note that Bazel's toolchain for 3.4.1 is tagged 3.4.0: https://github.com/bazelbuild/bazel-toolchains/releases/tag/3.4.0 Unblocking envoyproxy/envoy#12123 Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
rebello95
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Jul 22, 2020
- Update bazel to 3.4.1 (depends on envoyproxy/envoy#12123) - Update envoy upstream to include ^ - Update rules apple and rules swift - Update our header map iteration to fix breaking changes upstream from envoyproxy/envoy#12103 Signed-off-by: Michael Rebello <me@michaelrebello.com>
KBaichoo
pushed a commit
to KBaichoo/envoy
that referenced
this pull request
Jul 30, 2020
Note that Bazel's toolchain for 3.4.1 is tagged 3.4.0: https://github.com/bazelbuild/bazel-toolchains/releases/tag/3.4.0. Depends on envoyproxy/envoy-build-tools#85. Signed-off-by: Michael Rebello me@michaelrebello.com Risk Level: Medium Testing: CI Docs Changes: N/A Release Notes: N/A Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
scheler
pushed a commit
to scheler/envoy
that referenced
this pull request
Aug 4, 2020
Note that Bazel's toolchain for 3.4.1 is tagged 3.4.0: https://github.com/bazelbuild/bazel-toolchains/releases/tag/3.4.0. Depends on envoyproxy/envoy-build-tools#85. Signed-off-by: Michael Rebello me@michaelrebello.com Risk Level: Medium Testing: CI Docs Changes: N/A Release Notes: N/A Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: scheler <santosh.cheler@appdynamics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that Bazel's toolchain for 3.4.1 is tagged 3.4.0: https://github.com/bazelbuild/bazel-toolchains/releases/tag/3.4.0.
Depends on envoyproxy/envoy-build-tools#85.
Signed-off-by: Michael Rebello me@michaelrebello.com
Risk Level: Medium
Testing: CI
Docs Changes: N/A
Release Notes: N/A