test: refactor header inclusion to speed up building (for test/extensions/filters/network/...)#12051
Merged
lizan merged 2 commits intoenvoyproxy:masterfrom Jul 14, 2020
Conversation
Signed-off-by: Muge Chen <mugechen@google.com>
foreseeable
requested review from
alyssawilk,
dio,
lizan,
mattklein123,
snowp and
zuercher
as code owners
ahedberg
approved these changes
Jul 13, 2020
foreseeable
changed the title
lizan
approved these changes
Jul 14, 2020
scheler
pushed a commit
to scheler/envoy
that referenced
this pull request
Aug 4, 2020
…ions/filters/network/...) (envoyproxy#12051) Commit Message: refactor header inclusion to speed up building Additional Description: Risk Level: low Testing: exsiting tests Docs Changes: N/A Release Notes: no Related Issues: envoyproxy#10917 Signed-off-by: Muge Chen <mugechen@google.com> Signed-off-by: scheler <santosh.cheler@appdynamics.com>
htuch
pushed a commit
that referenced
this pull request
Aug 28, 2020
We need to reduce resource consumption of test compilation by simplifying mock library inclusions. #10917 One way to do that is to break the monolithic mock headers into different mock classes and then refactor the code base (like #12053 #12051 #11797) It's hard to refactor them manually. So I wrote headersplit, a tool based on libclang and python to help me divide the monolithic mock header and replace includes after dividing automatically. This tool can also generate building time comparison between before/after refactoring. Risk level: low Testing: Build succeeds. Signed-off-by: Muge Chen <mugechen@google.com>
clarakosi
pushed a commit
to clarakosi/envoy
that referenced
this pull request
Sep 3, 2020
) We need to reduce resource consumption of test compilation by simplifying mock library inclusions. envoyproxy#10917 One way to do that is to break the monolithic mock headers into different mock classes and then refactor the code base (like envoyproxy#12053 envoyproxy#12051 envoyproxy#11797) It's hard to refactor them manually. So I wrote headersplit, a tool based on libclang and python to help me divide the monolithic mock header and replace includes after dividing automatically. This tool can also generate building time comparison between before/after refactoring. Risk level: low Testing: Build succeeds. Signed-off-by: Muge Chen <mugechen@google.com> Signed-off-by: Clara Andrew-Wani <candrewwani@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Muge Chen mugechen@google.com
Refactor mock class include directive after dividing test/server/mocks.h (#11649)
Since the refactoring affects ~100 files so I split it up to several pull requests (previous one #11952)
Building time comparison for affected tests: see spreadsheet at #10917 comment
Commit Message: refactor header inclusion to speed up building
Additional Description:
Risk Level: low
Testing: exsiting tests
Docs Changes: N/A
Release Notes: no
Related Issues: #10917
\cc @ahedberg @bbarenblat