test: refactor header inclusion to speed up building (for test/server/...)#12045
Merged
junr03 merged 3 commits intoenvoyproxy:masterfrom Jul 14, 2020
Merged
test: refactor header inclusion to speed up building (for test/server/...)#12045junr03 merged 3 commits intoenvoyproxy:masterfrom
junr03 merged 3 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Muge Chen <mugechen@google.com>
foreseeable
changed the title
ahedberg
suggested changes
Jul 13, 2020
Contributor
ahedberg
left a comment
ahedberg
left a comment
There was a problem hiding this comment.
Looks good to me assuming CI comes back clean.
Can you try to merge upstream into this PR? The following should work (note, don't rebase, or that makes the diff hard to read):
# Update your local versions of the upstream branches
git fetch upstream
git checkout <feature-name>
# Apply missing changes on upstream/master to your local master
git merge upstream/master
Signed-off-by: Muge Chen <mugechen@google.com>
foreseeable
changed the title
foreseeable
changed the title
Contributor
Author
I merged it, now the conflicts has been resolved. But the CI still fails. It seems failed on some flaky tests. |
junr03
approved these changes
Jul 14, 2020
scheler
pushed a commit
to scheler/envoy
that referenced
this pull request
Aug 4, 2020
…/...) (envoyproxy#12045) Commit Message: refactor header inclusion to speed up building (for test/server/...) Additional Description: Risk Level: low Testing: existing tests Docs Changes: N/A Release Notes: no Related Issues: envoyproxy#10917 Signed-off-by: Muge Chen <mugechen@google.com> Signed-off-by: scheler <santosh.cheler@appdynamics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Muge Chen mugechen@google.com
Refactor mock class include directive after dividing test/server/mocks.h (#11649)
Since the refactoring affects ~100 files so I split it up to several pull requests (previous one #11952)
Building time comparison for affected tests: see spreadsheet at #10917 comment
Commit Message: refactor header inclusion to speed up building
Additional Description:
Risk Level: low
Testing: exsiting tests
Docs Changes: N/A
Release Notes: no
Related Issues: #10917
\cc @ahedberg @bbarenblat