android: add SUPPORTS_PTHREAD_GETNAME_NP definition#12011
android: add SUPPORTS_PTHREAD_GETNAME_NP definition#12011mattklein123 merged 12 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: Alan Chiu <achiu@lyft.com>
|
@jmarantz think you made the original change, if you don't mind taking a look. |
Signed-off-by: Alan Chiu <achiu@lyft.com>
include/envoy/common/platform.h
Outdated
| #endif | ||
|
|
||
| #ifdef __linux__ | ||
| #define SUPPORTS_PTHREAD_GETNAME_NP |
There was a problem hiding this comment.
suggest defining it to 1 or 0, rather than defining/not-defining it. That would make it less cumbersome to use in logical expressions at call-sites.
I think that's more consistent with other similar definitions in this file.
| getaffinity | ||
| gethostname | ||
| getifaddrs | ||
| getname |
There was a problem hiding this comment.
it looks like this is not needed; maybe it was in an intermediate state of this PR?
If I'm wrong go ahead an put it back.
There was a problem hiding this comment.
It's complaining for the comment I wrote which uses pthread_getname_np
There was a problem hiding this comment.
pretty sure you can wrap the word in back ticks (maybe double back ticks?) to avoid the spell checker, i think thats the preferred way to handle these special words
jmarantz
left a comment
jmarantz
left a comment
There was a problem hiding this comment.
Looks fine generally, except for nits.
@envoyproxy/senior-maintainers
Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: Alan Chiu <achiu@lyft.com>
|
@jmarantz Thanks for reviewing! I updated the PR with your feedback |
jmarantz
left a comment
jmarantz
left a comment
There was a problem hiding this comment.
@envoyproxy/senior-maintainers
snowp
left a comment
snowp
left a comment
There was a problem hiding this comment.
Thanks, this looks good just one comment on the spelling stuff
| getaffinity | ||
| gethostname | ||
| getifaddrs | ||
| getname |
There was a problem hiding this comment.
pretty sure you can wrap the word in back ticks (maybe double back ticks?) to avoid the spell checker, i think thats the preferred way to handle these special words
Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: Alan Chiu <achiu@lyft.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 12011 in repo envoyproxy/envoy |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…-supports_pthread_getname_np-definition Signed-off-by: Alan Chiu <achiu@lyft.com>
|
/azp run |
|
Pull request contains merge conflicts. |
…-supports_pthread_getname_np-definition Signed-off-by: Alan Chiu <achiu@lyft.com>
|
@jmarantz Thank you for the approval again! |
|
thank you @junr03 @mattklein123 ! |
Signed-off-by: Alan Chiu <achiu@lyft.com> Signed-off-by: scheler <santosh.cheler@appdynamics.com>
7 participants
Mirroring the PR: #11863
pthread_getname_npis introduced in Android API 26Introduced here: #11440
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message: android: add SUPPORTS_PTHREAD_GETNAME_NP definition
Additional Description:
Risk Level: low
Testing: ci
Docs Changes: n/a
Release Notes: n/a
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]