Merged
Conversation
Signed-off-by: Dan Zhang <danzh@google.com>
Contributor
Author
|
This should unblock #11941 |
Contributor
Author
|
/assign @wu-bin |
wu-bin
reviewed
Jul 8, 2020
Comment on lines
+88
to
+89
| SetQuicReloadableFlag(quic_disable_version_draft_27, use_http3); | ||
| SetQuicReloadableFlag(quic_disable_version_draft_25, use_http3); |
Contributor
There was a problem hiding this comment.
Note the two flags are quic_disable_*, it seems you meant !use_http3.
Comment on lines
+99
to
+100
| SetQuicReloadableFlag(quic_disable_version_draft_27, GetParam()); | ||
| SetQuicReloadableFlag(quic_disable_version_draft_25, GetParam()); |
Comment on lines
+67
to
+68
| SetQuicReloadableFlag(quic_disable_version_draft_27, use_http3); | ||
| SetQuicReloadableFlag(quic_disable_version_draft_25, use_http3); |
Comment on lines
294
to
297
| // The BPF filter looks at the 1st word of connection id in the packet | ||
| // header. And currently all QUIC versions support 8 bytes connection id. So | ||
| // create connections with the first 4 bytes of connection id different from each | ||
| // other so they should be evenly distributed. |
Contributor
There was a problem hiding this comment.
btw, we have change the BPF internally to inspect the 4 bytes starting from byte 1 (0-based). You may want to do the same here.
Contributor
Author
There was a problem hiding this comment.
ACK. I will make another change accordingly. What's the reason behind the change?
Signed-off-by: Dan Zhang <danzh@google.com>
Contributor
Author
|
/assign @htuch |
Contributor
|
@danzh2010 despite https://github.com/envoyproxy/envoy/blob/master/source/extensions/extensions_build_config.bzl#L165 there is still no way to enable QUIC yet right? |
scheler
pushed a commit
to scheler/envoy
that referenced
this pull request
Aug 4, 2020
Update to commit b2b8ff25f5a565324b93411ca29c3403ccbca969 Risk Level: low Testing: existing tests pass Signed-off-by: Dan Zhang <danzh@google.com> Signed-off-by: scheler <santosh.cheler@appdynamics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dan Zhang danzh@google.com
Update to commit b2b8ff25f5a565324b93411ca29c3403ccbca969
Risk Level: low
Testing: existing tests pass