Merged
Conversation
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
alyssawilk
approved these changes
Jul 6, 2020
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
Awesome, thank you!
can you tag the PR as fixing the issue before merging?
alyssawilk
reviewed
Jul 6, 2020
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
FWIW I don't think we need to keep trace logs. Do we have logs turned up to trace to make sure we get coverage of logging functions?
Merged
Member
Author
Yeah that's the case. |
Contributor
|
hm, I'm mildly concerned it'll make things more laggy but it passes this run and we can always revert if it makes things flaky. Feel free to go for it |
Member
|
Potential followup idea: pipe the output through grep for |
scheler
pushed a commit
to scheler/envoy
that referenced
this pull request
Aug 4, 2020
Signed-off-by: Lizan Zhou <lizan@tetrate.io> Signed-off-by: scheler <santosh.cheler@appdynamics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11860
Signed-off-by: Lizan Zhou lizan@tetrate.io