Skip to content

admission control: Use less iterations in integration test#11760

Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
tonya11en:fix_admctl_test
Jun 26, 2020
Merged

admission control: Use less iterations in integration test#11760
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
tonya11en:fix_admctl_test

Conversation

@tonya11en
Copy link
Member

@tonya11en tonya11en commented Jun 25, 2020

The admission control integration test occasionally times out when running through CI with a TSAN build (#11758). To address this, the admission control integration test now performs less iterations.

Local testing does not exhibit the timeouts observed in CI after ~1000 runs. Prior to this patch it was easily reproduced.

//test/extensions/filters/http/admission_control:admission_control_integration_test PASSED in 99.0s
  Stats over 1000 runs: max = 99.0s, min = 96.1s, avg = 97.7s, dev = 0.4s

Risk Level: Negligible
Testing: 1000 TSAN runs of integration test
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Tony Allen <tony@allen.gg>
@tonya11en tonya11en requested a review from mattklein123 as a code owner June 25, 2020 22:10
@mattklein123 mattklein123 self-assigned this Jun 25, 2020
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@asraa
Copy link
Contributor

asraa commented Jun 26, 2020

@tonya11en Could you try merging master again? I'm not sure what the reason for the circle ci tests not passing, but that has fixed the issue before @lizan

@mattklein123 mattklein123 merged commit 84d09df into envoyproxy:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants