admission control: Use less iterations in integration test#11760
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Jun 26, 2020
Merged
admission control: Use less iterations in integration test#11760mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Tony Allen <tony@allen.gg>
Contributor
|
@tonya11en Could you try merging master again? I'm not sure what the reason for the circle ci tests not passing, but that has fixed the issue before @lizan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The admission control integration test occasionally times out when running through CI with a TSAN build (#11758). To address this, the admission control integration test now performs less iterations.
Local testing does not exhibit the timeouts observed in CI after ~1000 runs. Prior to this patch it was easily reproduced.
Risk Level: Negligible
Testing: 1000 TSAN runs of integration test
Docs Changes: n/a
Release Notes: n/a