Skip to content

Subject: Porting Envoy to C++17 #11570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aimless404 wants to merge 23 commits into from
Closed

Subject: Porting Envoy to C++17 #11570

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
d5644c4
Subject: porting Envoy to C++17
Jun 11, 2020
b8462a2
Subject: fixing the CI builds
Jun 12, 2020
b38c8d9
fix of a bug (loss of precision when doing implicit conversion)
Jun 15, 2020
1b35238
added compiler flag to silence incorrect MSVC warning
Jun 15, 2020
93991ef
trying to see if adding external dep in build solves linker issue
Jun 22, 2020
2707547
another attempt to fix msvc linkage problems
Jun 22, 2020
09d2ed6
trying one last time
Jun 23, 2020
07a5d44
fixing the windows ci and get rid of the warnings
Jun 26, 2020
f477318
api builds fix
Jun 26, 2020
807d4c3
trying to fix api ci
Jun 26, 2020
f7726fd
does this fix ci problem
Jun 26, 2020
713e306
get rid of the separate c++14 flag added to clang_tools.bzl
Jun 29, 2020
da4c5cc
getting rid of unnecessary c++ flag
Jun 30, 2020
c9c2799
getting rid of unnecessary c++ flag
Jun 30, 2020
6a7a254
getting ready for submission
Jul 1, 2020
16f981f
add macos flag
Jul 1, 2020
89e1872
add the flag to macos build
Jul 1, 2020
9423af5
fixing macos c++17 flag
Jul 1, 2020
5c0b94f
adding the flags in envoy_internal.bzl back because they are failing …
Jul 1, 2020
711507a
to force the rerun of CI
Jul 2, 2020
449856c
applying a patch to quiche to fix a weird MSVC problem in absl::const…
Jul 7, 2020
243de00
actually making sure the patch applies correctly
Jul 7, 2020
2aa9ada
Revert "to force the rerun of CI"
Jul 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ build --action_env=BAZEL_LINKOPTS=-lm
build --host_javabase=@bazel_tools//tools/jdk:remote_jdk11
build --javabase=@bazel_tools//tools/jdk:remote_jdk11
build --enable_platform_specific_config
build --cxxopt=-std=c++17

@lizan lizan Jun 29, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build:linux?

@aimless404 aimless404 Jun 30, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes


# Enable position independent code, this option is not supported on Windows and default on on macOS.
build:linux --copt=-fPIC
Expand Down Expand Up @@ -104,9 +105,11 @@ build:libc++ --action_env=BAZEL_CXXOPTS=-stdlib=libc++
build:libc++ --action_env=BAZEL_LINKLIBS=-l%:libc++.a:-l%:libc++abi.a:-lm
build:libc++ --define force_libcpp=enabled


# Optimize build for binary size reduction.
build:sizeopt -c opt --copt -Os


# Test options
build --test_env=HEAPCHECK=normal --test_env=PPROF_PATH

Expand Down Expand Up @@ -192,6 +195,7 @@ build:docker-sandbox --define=EXECUTOR=remote
build:docker-sandbox --experimental_docker_verbose
build:docker-sandbox --experimental_enable_docker_sandbox


build:docker-clang --config=docker-sandbox
build:docker-clang --config=rbe-toolchain-clang

Expand Down Expand Up @@ -243,6 +247,7 @@ build:windows --define manual_stamp=manual_stamp
build:windows --copt="-DCARES_STATICLIB"
build:windows --copt="-DNGHTTP2_STATICLIB"
build:windows --copt="-DCURL_STATICLIB"
build:windows --cxxopt="/std:c++17"

# Required to work around build defects on Windows MSVC cl
# Unguarded gcc pragmas in quiche are not recognized by MSVC
Expand Down
Loading