Skip to content

Revert "[http] Remove exceptions from HTTP/1 codec callbacks (#11101)"#11194

Merged
asraa merged 1 commit intoenvoyproxy:masterfrom
asraa:revert-exception
May 15, 2020
Merged

Revert "[http] Remove exceptions from HTTP/1 codec callbacks (#11101)"#11194
asraa merged 1 commit intoenvoyproxy:masterfrom
asraa:revert-exception

Conversation

@asraa
Copy link
Contributor

@asraa asraa commented May 14, 2020

This reverts commit 3550a7a. (#11101)

Not to be merged until #10878 actions are complete.

Signed-off-by: Asra Ali asraa@google.com

@asraa
Revert "[http] Remove exceptions from HTTP/1 codec callbacks (envoypr…
1674752 
…oxy#11101)"

This reverts commit 3550a7a.

Signed-off-by: Asra Ali <asraa@google.com>
@asraa asraa requested a review from jmarantz May 14, 2020 12:58
@asraa
Copy link
Contributor Author

asraa commented May 14, 2020

/retest

@repokitteh-read-only
Copy link

repokitteh-read-only bot commented May 14, 2020

🤷‍♀️ nothing to rebuild.

🐱

Caused by: a #11194 (comment) was created by @asraa.

see: more, trace.

@asraa
Copy link
Contributor Author

asraa commented May 14, 2020 •
edited
Loading

/azp run envoy-presubmit

@azure-pipelines
Copy link

azure-pipelines bot commented May 14, 2020

Command 'rerun' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@azure-pipelines
Copy link

azure-pipelines bot commented May 14, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@asraa asraa merged commit 5083a9a into envoyproxy:master May 15, 2020
@asraa asraa deleted the revert-exception branch May 15, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmarantz jmarantz jmarantz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asraa @jmarantz