Skip to content

Cleanup: add const for access_log_filter::evaluate function#11002

Merged
htuch merged 3 commits intoenvoyproxy:masterfrom
qiwzhang:access_log_filter
May 1, 2020
Merged

Cleanup: add const for access_log_filter::evaluate function#11002
htuch merged 3 commits intoenvoyproxy:masterfrom
qiwzhang:access_log_filter

Conversation

@qiwzhang
Copy link
Contributor

Signed-off-by: Wayne Zhang qiwzhang@google.com

Add const to the function so that const object can be used to call

const AccessLogFilter& filter;
filter.evaluate(...) ;

Commit Message:
Additional Description:
Risk Level: None
Testing: None
Docs Changes: No
Release Notes: No

Signed-off-by: Wayne Zhang <qiwzhang@google.com>
Signed-off-by: Wayne Zhang <qiwzhang@google.com>
Signed-off-by: Wayne Zhang <qiwzhang@google.com>
@qiwzhang
Copy link
Contributor Author

@htuch @lizan could you help to merge this

Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit 85a6784 into envoyproxy:master May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants