Fixed test build failures under gcc 9#10965
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Apr 28, 2020
dmitri-d:fix-test-failures-under-gcc
Merged
Fixed test build failures under gcc 9#10965mattklein123 merged 2 commits intoenvoyproxy:masterfrom dmitri-d:fix-test-failures-under-gcc
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
dmitri-d:fix-test-failures-under-gcc
Conversation
Signed-off-by: Dmitri Dolguikh <ddolguik@redhat.com>
lizan
reviewed
Apr 27, 2020
Signed-off-by: Dmitri Dolguikh <ddolguik@redhat.com>
lizan
approved these changes
Apr 27, 2020
| // segments, which trigger some inconsistent handling as described in that | ||
| // bug. | ||
| uint32_t num_bytes = 1 + data[index] & 0x7; | ||
| uint32_t num_bytes = (1 + data[index]) & 0x7; |
Contributor
There was a problem hiding this comment.
If you look at the comment above, I think the intent of this line was:
uint32_t num_bytes = 1 + (data[index] & 0x7);
Contributor
There was a problem hiding this comment.
Change to initial byte count has resolved fuzz crash 30088 and removed need for additional testing of num_bytes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dmitri Dolguikh ddolguik@redhat.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message: Fixed test build failures under gcc 9
Additional Description:
Risk Level: low
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]