Skip to content

http: replace vector/reserve with InlinedVector in codec helper #10941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattklein123 merged 2 commits into from
Apr 25, 2020
Merged

http: replace vector/reserve with InlinedVector in codec helper #10941

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fb1120
http: replace vector/reserve with InlinedVector in codec helper
mattklein123 Apr 24, 2020
fd0286f
fix clang-tidy
mattklein123 Apr 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions source/common/http/codec_helper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
#pragma once

#include <vector>

#include "envoy/http/codec.h"

#include "common/common/assert.h"

#include "absl/container/inlined_vector.h"

namespace Envoy {
namespace Http {

Expand Down Expand Up @@ -54,11 +54,6 @@ class StreamCallbackHelper {
bool local_end_stream_{};

protected:
StreamCallbackHelper() {
// Set space for 8 callbacks (64 bytes).
callbacks_.reserve(8);
}

void addCallbacks_(StreamCallbacks& callbacks) {
ASSERT(!reset_callbacks_started_ && !local_end_stream_);
callbacks_.push_back(&callbacks);
Expand All @@ -82,7 +77,7 @@ class StreamCallbackHelper {
}

private:
std::vector<StreamCallbacks*> callbacks_;
absl::InlinedVector<StreamCallbacks*, 8> callbacks_;
bool reset_callbacks_started_{};
uint32_t high_watermark_callbacks_{};
};
Expand Down