Skip to content

Windows: Tag failing tests#10940

Merged
zuercher merged 1 commit intoenvoyproxy:masterfrom
greenhouse-org:tag-failing-windows-tests
Apr 27, 2020
Merged

Windows: Tag failing tests#10940
zuercher merged 1 commit intoenvoyproxy:masterfrom
greenhouse-org:tag-failing-windows-tests

Conversation

@sunjayBhatia
Copy link
Member

@sunjayBhatia sunjayBhatia commented Apr 24, 2020

Commit Message: Tag tests that fail on Windows with fails_on_windows
Additional Description:

  • 139 tests tagged in total now, a few of which are flaky and don't fail every invocation
  • To enable contributors are to work on fixing these failed tests and to give a view into what progress still needs to be made
  • When we are able to get CI working to build/run tests on Windows, we can ignore the tagged tests and untag them as they are fixed
  • It appears a large portion of the tests will be fixable with a few patches
  • there are also assumptions in test setup/teardown etc. that are not compatible with Windows at the moment
  • a large percentage of the failing tests are integration tests

Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A

- so contributors are enabled to work on them
- tagged with fails_on_windows

Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
@sunjayBhatia sunjayBhatia mentioned this pull request Apr 24, 2020
Copy link
Member

@zuercher zuercher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zuercher zuercher merged commit 8951b3f into envoyproxy:master Apr 27, 2020
@sunjayBhatia sunjayBhatia deleted the tag-failing-windows-tests branch April 27, 2020 18:45
spenceral added a commit to spenceral/envoy that referenced this pull request Apr 27, 2020
Signed-off-by: Spencer Lewis <slewis@squareup.com>

* master:
  fault injection: add support for setting gRPC status (envoyproxy#10841)
  tests: tag tests that fail on Windows with fails_on_windows (envoyproxy#10940)
  Fix typo on Postgres Proxy documentation. (envoyproxy#10930)
  fuzz: improve header/data stop/continue modeling in HCM fuzzer. (envoyproxy#10931)
  gzip filter: allow setting zlib compressor's chunk size (envoyproxy#10508)
  http: replace vector/reserve with InlinedVector in codec helper (envoyproxy#10941)
  stats: add utilities to create stats from a vector of tokens, mixing dynamic and symbolic elements. (envoyproxy#10735)
  hcm: avoid invoking 100-continue handling on decode filter. (envoyproxy#10929)
  prometheus stats: Correctly group lines of the same metric name. (envoyproxy#10833)
  status: Fix ASAN error in Status payload handling (envoyproxy#10906)
  path: Fix merge slash for paths ending with slash and present query args (envoyproxy#10922)
  compressor filter: add benchmark (envoyproxy#10464)
  xray: expected_span_name is not captured by the lambda with MSVC (envoyproxy#10934)
  ci: update before purge in cleanup (envoyproxy#10938)
  tracer: Improve test coverage for x-ray (envoyproxy#10890)
  Revert "init: order dynamic resource initialization to make RTDS always be first (envoyproxy#10362)" (envoyproxy#10919)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants