ip tagging: remember tags as builtins#10856
Conversation
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
|
cc: @jmarantz |
jmarantz
left a comment
jmarantz
left a comment
There was a problem hiding this comment.
Thanks for doing this; one basic question.
I think the question didn't make it through... |
| hit_(stat_name_set_->add("hit")), no_hit_(stat_name_set_->add("no_hit")), | ||
| total_(stat_name_set_->add("total")) { | ||
| no_hit_(stat_name_set_->add("no_hit")), total_(stat_name_set_->add("total")), | ||
| unknown_tag_(stat_name_set_->add("unknown_tag.hit")) { |
There was a problem hiding this comment.
I had thought what we could do was walk through the tags and add all of them as builtins so we don't map them all to unknown. Was there some reason you didn't want to do it that way?
There was a problem hiding this comment.
Eh?
I am doing that, in the loop that discovers the tags... the unknown_tag_ is needed because getBuiltin() needs a fallback parameter...
| } | ||
|
|
||
| tag_data.emplace_back(ip_tag.ip_tag_name(), cidr_set); | ||
| stat_name_set_->rememberBuiltin(absl::StrCat(ip_tag.ip_tag_name(), ".hit")); |
There was a problem hiding this comment.
Sorry; my bad. OK this looks great! Thanks!
jmarantz
left a comment
jmarantz
left a comment
There was a problem hiding this comment.
@envoyproxy/senior-maintainers
| } | ||
|
|
||
| tag_data.emplace_back(ip_tag.ip_tag_name(), cidr_set); | ||
| stat_name_set_->rememberBuiltin(absl::StrCat(ip_tag.ip_tag_name(), ".hit")); |
There was a problem hiding this comment.
Sorry; my bad. OK this looks great! Thanks!
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com> Signed-off-by: pengg <pengg@google.com>
3 participants
Signed-off-by: Raul Gutierrez Segales rgs@pinterest.com