Skip to content

Fix hiding of virtual function in FilterChainBenchmarkFixture#10850

Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
nezdolik:patch-1
Apr 20, 2020
Merged

Fix hiding of virtual function in FilterChainBenchmarkFixture#10850
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
nezdolik:patch-1

Conversation

@nezdolik
Copy link
Member

Currently Setup function in FilterChainBenchmarkFixture is hiding virtual function in parent class benchmark::Fixture :

   virtual void SetUp(State& st) { SetUp(const_cast<const State&>(st)); }
                ^~~~~
test/server/filter_chain_benchmark_test.cc:169:8: error:   by 'virtual void Envoy::Server::FilterChainBenchmarkFixture::SetUp(const benchmark::State&)' [-Werror=overloaded-virtual]
   void SetUp(const ::benchmark::State& state) override {
        ^~~~~

Risk Level: Low
Testing: Covered by existing tests

Signed-off-by: Kateryna Nezdolii <nezdolik@spotify.com>
@mattklein123 mattklein123 merged commit 5b7d3af into envoyproxy:master Apr 20, 2020
penguingao pushed a commit to penguingao/envoy that referenced this pull request Apr 22, 2020
Signed-off-by: Kateryna Nezdolii <nezdolik@spotify.com>
Signed-off-by: pengg <pengg@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants