Add statusor words to spellcheck dictionary#10794
Closed
FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg wants to merge 1 commit intoenvoyproxy:masterfrom
Closed
Add statusor words to spellcheck dictionary#10794FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg wants to merge 1 commit intoenvoyproxy:masterfrom
FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg wants to merge 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Nicolas Flacco <nflacco@lyft.com>
Merged
Contributor
|
I working on the proper solution to this problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: The pedantic spellcheck when run manually doesn't catch words in third party files (ie the statusor); however on trying to update our Envoy fork from master I got spellcheck errors on pushing. This PR adds the words that fixed this to the dictionary.
Risk Level: Low
Testing: None
Docs Changes: None
Release Notes: None