Windows compilation: ensure statusCodeToString has no control paths that do not return#10777
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Apr 15, 2020
greenhouse-org:http-status-return-paths
Merged
Windows compilation: ensure statusCodeToString has no control paths that do not return#10777mattklein123 merged 3 commits intoenvoyproxy:masterfrom greenhouse-org:http-status-return-paths
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
greenhouse-org:http-status-return-paths
Conversation
Member
Author
|
If an exception is more desirable here let us know, we chose to assert as there is no usage of this class other than in tests (also we can add tests as needed as well). |
Member
Author
|
Pulled out in a separate PR instead of #10542 to enable more discussion and as it is a minor change for Linux semantics |
Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io> Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io> Co-authored-by: William A Rowe Jr <wrowe@pivotal.io> Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
Contributor
|
@asraa and @yanavlasov this is the patch to address the missing default control in PR10550 if someone can assume review of this PR. |
asraa
reviewed
Apr 15, 2020
asraa
reviewed
Apr 15, 2020
yanavlasov
requested changes
Apr 15, 2020
same result, macro adds a PANIC directly Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io> Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io> Signed-off-by: William A Rowe Jr <wrowe@pivotal.io> Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
yanavlasov
previously approved these changes
Apr 15, 2020
mattklein123
requested changes
Apr 15, 2020
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Member
Author
|
/retest |
|
🔨 rebuilding |
mattklein123
approved these changes
Apr 15, 2020
nareddyt
added a commit
to nareddyt/envoy
that referenced
this pull request
Apr 23, 2020
Description: PR envoyproxy#10777 introduces `NOT_REACHED_GCOVR_EXCL_LINE`, but this macro is defined in `assert.h` Signed-off-by: Teju Nareddy <nareddyt@google.com>
mattklein123
pushed a commit
that referenced
this pull request
Apr 23, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Fix Windows compilation to ensure all control paths return, any unmatched status code that is unexpected is taken care of by adding NOT_REACHED_GCOVR_EXCL_LINE to induce a PANIC, related to #10550
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A