cluster: warm up strict dns cluster with 0 hosts#10728
Merged
asraa merged 1 commit intoenvoyproxy:masterfrom Apr 10, 2020
Merged
cluster: warm up strict dns cluster with 0 hosts#10728asraa merged 1 commit intoenvoyproxy:masterfrom
asraa merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Member
|
I believe this fixes #3566 |
ggreenway
approved these changes
Apr 9, 2020
Contributor
Author
|
@ggreenway I didn't realize there was an old issue... |
venilnoronha
added a commit
to vmware-allspark/envoy
that referenced
this pull request
Apr 21, 2020
istio/istio#22837 (comment) envoyproxy#10728 istio/istio#20981 Signed-off-by: Venil Noronha <veniln@vmware.com>
lambdai
added a commit
to lambdai/envoy-dai
that referenced
this pull request
Apr 23, 2020
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
lambdai
added a commit
to lambdai/envoy-dai
that referenced
this pull request
Apr 23, 2020
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
This was referenced Apr 23, 2020
istio-testing
pushed a commit
to istio/envoy
that referenced
this pull request
Apr 23, 2020
…oyproxy#10728 (#199) * cluster: warm up strict dns cluster with 0 hosts (envoyproxy#10728) Signed-off-by: Yuchen Dai <silentdai@gmail.com> * backport fixup Signed-off-by: Yuchen Dai <silentdai@gmail.com>
istio-testing
pushed a commit
to istio/envoy
that referenced
this pull request
Apr 24, 2020
…200) Signed-off-by: Yuchen Dai <silentdai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Sometime control plane send strict dns cluster with no endpoint. No hosts to resolve so the cluster is never warmed up.
Choose to warmed up the cluster immediately, as if the resolver returns 0 available addresses.
Alternative solution: reject the cluster config.
Signed-off-by: Yuchen Dai silentdai@gmail.com
Risk Level: LOW. Cluster is never guaranteed to have available hosts.
Testing:
Docs Changes:
Release Notes:
Fixes #3566
[Optional Deprecated:]