Fixing pending_response_done_ assertion location in HTTP/1.x codec_impl#10718
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Apr 9, 2020
Merged
Conversation
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Contributor
Author
|
/cc @euroelessar - Can you please have a quick look to make sure that it makes sense |
euroelessar
approved these changes
Apr 9, 2020
Contributor
euroelessar
left a comment
euroelessar
left a comment
There was a problem hiding this comment.
Yes, this looks equivalent to a state before my change.
alyssawilk
approved these changes
Apr 9, 2020
mattklein123
approved these changes
Apr 9, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks. I'm going to circle back here and see if I can figure out how to clean this up a bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing an assertion on
pending_response_done_that was added in #10561, and should only be called for certain case.Risk Level: Low
Testing: Added the fuzz testcase that caused a failure
Fixes OSS fuzz test: 5102523695497216
Signed-off-by: Adi Suissa-Peleg adip@google.com