Skip to content

Master PR for #10713: Fix static shared_ptr in request id extension #10714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattklein123 merged 2 commits into from
Apr 8, 2020
Merged

Master PR for #10713: Fix static shared_ptr in request id extension #10714

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
223fbcc
master fix
asraa Apr 8, 2020
1d0de22
fix version
asraa Apr 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/root/intro/version_history.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ Version history

1.15.0 (Pending)
================
* request_id_extension: fixed static initialization for noop request id extension.
Comment thread
asraa marked this conversation as resolved.

1.14.0 (April 8, 2020)
======================
Expand Down
4 changes: 2 additions & 2 deletions source/common/http/request_id_extension_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ RequestIDExtensionFactory::defaultInstance(Envoy::Runtime::RandomGenerator& rand
}

RequestIDExtensionSharedPtr RequestIDExtensionFactory::noopInstance() {
static RequestIDExtensionSharedPtr global = std::make_shared<NoopRequestIDExtension>();
return global;
MUTABLE_CONSTRUCT_ON_FIRST_USE(std::shared_ptr<RequestIDExtension>,
std::make_shared<NoopRequestIDExtension>());
}

} // namespace Http
Expand Down