thrift: fix test tooling for python3#10702
Closed
zuercher wants to merge 5 commits intoenvoyproxy:masterfrom
Closed
thrift: fix test tooling for python3#10702zuercher wants to merge 5 commits intoenvoyproxy:masterfrom
zuercher wants to merge 5 commits intoenvoyproxy:masterfrom
Conversation
Applies a patch to the python libraries used in test to enable python3 compatibility. Related to envoyproxy#10701 and envoyproxy#4552. Risk Level: low, test only Testing: n/a Docs Changes: n/a Release Notes: n/a Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Member
Author
|
So evidently there's some more stuff in the python that's compatible with whatever version of python3 I tested against and what's used in most of our CI, but not the version used in coverage. Will try to make time to revisit this again later. |
Member
Author
|
/wait |
Member
Author
|
/retest |
|
🔨 rebuilding |
Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Member
Author
|
/wait |
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
stale
bot
added
the
stale
Member
|
@zuercher was there a reason for abandoning this PR ? we are looking at this again with a view to removing the dependency on six |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies a patch to the python libraries used in
test to enable python3 compatibility. Related
to #10701 and #4552.
Risk Level: low, test only
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Signed-off-by: Stephan Zuercher zuercher@gmail.com