tools: adding some version notes alphabetization checks to check_format#10695
Merged
mattklein123 merged 4 commits intoenvoyproxy:masterfrom Apr 8, 2020
Merged
tools: adding some version notes alphabetization checks to check_format#10695mattklein123 merged 4 commits intoenvoyproxy:masterfrom
mattklein123 merged 4 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Member
|
Yes amazing!!! Can you merge master? |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
asraa
reviewed
Apr 8, 2020
Contributor
asraa
left a comment
asraa
left a comment
There was a problem hiding this comment.
Thank you! Just one small comment
| reportError("Version history line malformed. " | ||
| "Does not match VERSION_HISTORY_NEW_LINE_REGEX in check_format.py\n %s" % line) | ||
| else: | ||
| first_word = match.groups()[0] |
Contributor
There was a problem hiding this comment.
Based on the * quantifier in VERSION_HISTORY_NEW_LINE_REGEX could this just be :? Is that OK? (Alphabetization makes sense of it, but just as a release note)
Contributor
Author
There was a problem hiding this comment.
I guess arguably - that'd be a useless release note but we should complain cleanly :-)
I'm doing a follow-up to make sure sentences end with . - OK if I change the * to + there, just for release reasons?
Contributor
There was a problem hiding this comment.
Yes, that seems like a better place! LGTM otherwise
Member
There was a problem hiding this comment.
OK sounds good I will force merge once the docs build passes.
asraa
approved these changes
Apr 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk Level: n/a
Testing: manual as seen by new release notes
Docs Changes: n/a
Release Notes: sort of...