ci: save a few GB disk space#10669
Conversation
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
ci/do_ci.sh
Outdated
| tar czf "${ENVOY_BUILD_DIR}"/envoy_binary.tar.gz -C "${ENVOY_SRCDIR}" build_"$1" build_"$1"_stripped | ||
|
|
||
| # Remove binaries to save space | ||
| rm -rf "${ENVOY_SRCDIR}"/build_"$1" "${ENVOY_SRCDIR}"/build_"$1"_stripped "${ENVOY_DELIVERY_DIR}"/envoy |
There was a problem hiding this comment.
cc @tonya11en I guess this might break your use case when you added cp_binary_for_outside_access
There was a problem hiding this comment.
Hmm yeah not sure why this was added. @tonya11en @LisaLudique can one of you take a look and see if we use this at Lyft somehow?
There was a problem hiding this comment.
Sorry I'm confused. Why would this break it? We are deleting after the copy which seems OK?
There was a problem hiding this comment.
Oh I see. You are deleting what we already copied. Yeah I'm sure this is going to break something. Can you maybe guard this with an env var and then just set it for CI?
There was a problem hiding this comment.
(Or if we decide that we don't want the copy we should just delete cp_binary_for_outside_access() entirely.
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks, one small comment comment. Also, aren't we going to pretty quickly come up against the size limit again? Do we need to ask AZP about larger disk allocations?
| ENVOY_DOCKER_BUILD_DIR: $(Build.StagingDirectory) | ||
| ENVOY_RBE: "true" | ||
| BAZEL_BUILD_EXTRA_OPTIONS: "--config=remote-ci --jobs=$(RbeJobs) --curses=no" | ||
| BAZEL_BUILD_EXTRA_OPTIONS: "--config=remote-ci --jobs=$(RbeJobs) --curses=no --experimental_repository_cache_hardlinks" |
There was a problem hiding this comment.
Can you add a comment on what this does and why we set it?
Yes we should ask AZP likely. Though it won't be quickly against the size limit again. We run all test in RBE which is not as disk constrained as in AZP (unless it prints huge logs that we download to AZP). The most disk consuming part is build-tools, i.e. our build image and bazel downloaded Go/Java SDK etc. |
|
Going to force merge this since release passed and we can unwedge folks. |
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
2 participants
Signed-off-by: Lizan Zhou lizan@tetrate.io