adaptive concurrency: Trigger minRTT calculation outside interval#10647
Merged
mattklein123 merged 5 commits intoenvoyproxy:masterfrom Apr 7, 2020
Merged
adaptive concurrency: Trigger minRTT calculation outside interval#10647mattklein123 merged 5 commits intoenvoyproxy:masterfrom
mattklein123 merged 5 commits intoenvoyproxy:masterfrom
Conversation
…setting lowest concurrency Signed-off-by: Tony Allen <tony@allen.gg>
Signed-off-by: Tony Allen <tony@allen.gg>
Member
|
Can you take a look at clang-tidy errors? /wait |
Signed-off-by: Tony Allen <tony@allen.gg>
mattklein123
requested changes
Apr 7, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks, LGTM with 1 small comment/question.
/wait
| // inaccurate minRTT measurement. Since the limit is already where it needs to be for a minRTT | ||
| // measurement, we should measure it again. | ||
| if (consecutive_min_concurrency_set_ >= 5) { | ||
| min_rtt_calc_timer_->enableTimer(std::chrono::milliseconds(0)); |
Member
There was a problem hiding this comment.
This won't end up spin looping because if this happens while not already in a window, this will start a process that waits for requests/responses to happen, right? Can you maybe put a clarifying comment about why this won't spin loop? This is also why you need the various inMinRTTSamplingWindow checks, right?
Member
Author
There was a problem hiding this comment.
I think any issues around spin looping are prevented first thing in enterMinRTTSamplingWindow. Added a comment to clarify this, but let me know if I addressed the right concern.
Signed-off-by: Tony Allen <tony@allen.gg>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch changes the adaptive concurrency filter's minRTT measurement behavior to additionally trigger a minRTT calculation if there have been 5 consecutive concurrency limit updates at the minimum concurrency. Previous minRTT behavior is still maintained, but the new condition resets the timer on the minRTT calculation.
The minRTT convergence times should be improved for little to no observable differences in filter behavior.
Risk Level: Low
Testing: Unit tests
Docs Changes: yes
Release Notes: yes