fuzz: handle stream resets in codec_impl_fuzz_test with HTTP/1.#10643
Merged
mattklein123 merged 5 commits intoenvoyproxy:masterfrom Apr 7, 2020
Merged
fuzz: handle stream resets in codec_impl_fuzz_test with HTTP/1.#10643mattklein123 merged 5 commits intoenvoyproxy:masterfrom
mattklein123 merged 5 commits intoenvoyproxy:masterfrom
Conversation
The HTTP/1 codec implies a connection close following a stream reset of any kind, including explicit resetStream(). This patch ensures that codec_impl_fuzz_test completes without any further connection use following a stream reset. Fixes oss-fuzz issue https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=21272. Risk level: Low Testing: Corpus entry added. Signed-off-by: Harvey Tuch <htuch@google.com>
asraa
reviewed
Apr 6, 2020
Contributor
asraa
left a comment
asraa
left a comment
There was a problem hiding this comment.
LGTM, thank you for fixing this! Small question about the usefulness of DebugMode in the class.
Signed-off-by: Harvey Tuch <htuch@google.com>
asraa
approved these changes
Apr 6, 2020
Contributor
asraa
left a comment
asraa
left a comment
There was a problem hiding this comment.
Ah, thanks for the clarification. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTTP/1 codec implies a connection close following a stream reset of
any kind, including explicit resetStream(). This patch ensures that
codec_impl_fuzz_test completes without any further connection use
following a stream reset.
Fixes oss-fuzz issue
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=21272.
Risk level: Low
Testing: Corpus entry added.
Signed-off-by: Harvey Tuch htuch@google.com