stream info: wire http protocol to the connection info#10627
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Apr 6, 2020
Merged
stream info: wire http protocol to the connection info#10627mattklein123 merged 2 commits intoenvoyproxy:masterfrom
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Kuat Yessenov <kuat@google.com>
alyssawilk
approved these changes
Apr 6, 2020
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
Wow, much simpler and cleaner than the last pass, thanks!
Contributor
|
Adding one reviewer from prior PR for cross-company review :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kuat Yessenov kuat@google.com
Description: populate HTTP codec protocol in outer connection stream info. Replacing overly large #10524 with a simpler change needed to support detection of HTTP in connection access loggers
Risk Level: low
Testing: unit, manual
Docs Changes: none
Release Notes: none