api: freeze of v2 API, cut v4alpha API.#10601
Closed
htuch wants to merge 3 commits intoenvoyproxy:masterfrom
Closed
api: freeze of v2 API, cut v4alpha API.#10601htuch wants to merge 3 commits intoenvoyproxy:masterfrom
htuch wants to merge 3 commits intoenvoyproxy:masterfrom
Conversation
Member
Author
|
FYI @mattklein123 @lizan. I'm going to be force pushing here etc. until it's ready to review, but this is a snapshot of where we're heading. |
Member
Author
|
This is now working for build/test/docs, generated APIs look sane (to me). What remains is cleanup of the Python code and |
Member
|
@htuch looks good for me only this API changes. |
htuch
force-pushed
the
v4alpha-upgrade
branch
2 times, most recently
from
c8e0f19 to
32e4edf
Compare
htuch
changed the title
Member
Author
|
@lizan @mattklein123 this is now ready for review for real. |
Member
|
@htuch Is it possible to split the tooling part out to another PR? |
Member
|
re: CI I think this doubles the format job which now takes 20 minutes, I guess we can split it to two part, format and protoxform. WDYT? |
Signed-off-by: Harvey Tuch <htuch@google.com>
Member
Author
|
@lizan I've corrected a performance problem and it's back to 12m. Will split out the tools diff to a distinct PR. |
Signed-off-by: Harvey Tuch <htuch@google.com>
htuch
added a commit
to htuch/envoy
that referenced
this pull request
Apr 3, 2020
This patch introduces the tools/docs for a new flow for protoxform: freeze. This performs a major version freeze and bump by modifying package_version_status. Tooling now needs to deal with 3 possible versions (v2, v3, v4alpha). The following contributions are made in the patch: * Tooling added to support v2 APIs freeze, transitioning v3 to active and generating v4alpha. * A new tool, merge_active_shadow.py, is introduced to combine hand-edited active v3 API protos with the v2 implied shadows for deprecated fields. * The type database now spans v2 and v3 (and implied v4alpha files). * api_proto_plugins can now take extra args on the Bazel CLI; this is used to plumb in the freeze arg to protoxform. * Docs are updated to reflect the v3 flow that developers should now follow. Part of envoyproxy#10355 This is the tools/docs component of envoyproxy#10601. See envoyproxy#10601 for the resulting API protos generated by a freeze/fix cycle. Risk level: Low (tooling only, no API changes yet) Testing: new golden protos tests for protoxform, unit tests for merge_active_shadow. Signed-off-by: Harvey Tuch <htuch@google.com>
Member
Author
Shikugawa
approved these changes
Apr 3, 2020
htuch
added a commit
that referenced
this pull request
Apr 7, 2020
This patch introduces the tools/docs for a new flow for protoxform: freeze. This performs a major version freeze and bump by modifying package_version_status. Tooling now needs to deal with 3 possible versions (v2, v3, v4alpha). The following contributions are made in the patch: * Tooling added to support v2 APIs freeze, transitioning v3 to active and generating v4alpha. * A new tool, merge_active_shadow.py, is introduced to combine hand-edited active v3 API protos with the v2 implied shadows for deprecated fields. * The type database now spans v2 and v3 (and implied v4alpha files) * api_proto_plugins can now take extra args on the Bazel CLI; this is used to plumb in the freeze arg to protoxform. Docs are updated to reflect the v3 flow that developers should now follow. Part of #10355 This is the tools/docs component of #10601. See #10601 for the resulting API protos generated by a freeze/fix cycle. Risk level: Low (tooling only, no API changes yet) Testing: new golden protos tests for protoxform, unit tests for merge_active_shadow. Signed-off-by: Harvey Tuch <htuch@google.com>
htuch
changed the title
Member
Author
|
Closing this out, will do a pure API PR instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch performs a major version freeze and bump by modifying package_version_status, using the tooling developed in #10636. Specifically:
Fixes #10355
Risk level: medium (entire API's files are modified, visually verified to ensure things look sane, all tests pass)
Testing: CI
Signed-off-by: Harvey Tuch htuch@google.com