config: use cluster check utility in grpc async client#10565
Closed
ramaraochavali wants to merge 2 commits intoenvoyproxy:masterfrom
Closed
config: use cluster check utility in grpc async client#10565ramaraochavali wants to merge 2 commits intoenvoyproxy:masterfrom
ramaraochavali wants to merge 2 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
Contributor
Author
|
Looks like failing other cases. Will fix and reopen later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: #10526 added support in
checkClustermethod to validate the type of cluster that can be used for calling external services. This PR refactorsAsyncClientFactoryImplto reuse that method and adds unit tests for that method.Risk Level: Low
Testing: Added unit tests
Docs Changes: N/A
Release Notes: N/A