http: max stream duration upstream support by Shikugawa · Pull Request #10531 · envoyproxy/envoy

Shikugawa · 2020-03-26T03:18:53Z

Signed-off-by: shikugawa rei@tetrate.io

Commit Message: To resolve #10274, adding max stream duration for upstream connection.
Additional Description:
Risk Level: Low
Testing: Unit / Integration
Docs Changes: Required
Release Notes: Required
Fixes: #10274

Signed-off-by: shikugawa <rei@tetrate.io>

repokitteh-read-only · 2020-03-26T03:18:58Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.

🐱

Caused by: #10531 was opened by Shikugawa.

see: more, trace.

Signed-off-by: shikugawa <rei@tetrate.io>

mattklein123

Thanks generally LGTM. Can you also make sure this is covered by an integration test?

/wait

include/envoy/upstream/upstream.h

source/common/http/codec_client.h

htuch · 2020-03-27T21:44:48Z

/lgtm api

Signed-off-by: shikugawa <rei@tetrate.io>

Shikugawa · 2020-03-30T18:36:35Z

It seems that disconnect with ActiveRequest is invalid because that emits request_encoder. It may lead to dangling references when clearing upstream requests.

Signed-off-by: shikugawa <rei@tetrate.io>

mattklein123

Thanks, looks like this is on the right track. A few comments to work on. Thank you!

/wait

include/envoy/upstream/upstream.h

test/integration/http2_integration_test.cc

test/integration/http_integration.cc

Signed-off-by: shikugawa <rei@tetrate.io>

mattklein123

Few more comments, thank you!

/wait

test/common/router/router_test.cc

test/integration/http_integration.h

source/common/router/upstream_request.cc

Signed-off-by: shikugawa <rei@tetrate.io>

htuch · 2020-04-07T14:51:35Z

Please merge master to pick up #10672. We no longer accept changes to v2 (without explicit exception), so any API modifications should happen in v3. If this PR is adding a new proto, please follow the updated instructions in https://github.com/envoyproxy/envoy/blob/master/api/STYLE.md#adding-an-extension-configuration-to-the-api.

Signed-off-by: shikugawa <rei@tetrate.io>

…tream-max-stream-duration Signed-off-by: shikugawa <rei@tetrate.io>

Signed-off-by: shikugawa <rei@tetrate.io>

mattklein123 · 2020-04-29T21:32:51Z

Please merge master.

/wait

…tream-max-stream-duration Signed-off-by: shikugawa <rei@tetrate.io>

htuch

/lgtm api

…tream-max-stream-duration Signed-off-by: shikugawa <rei@tetrate.io>

Signed-off-by: shikugawa <rei@tetrate.io>

mattklein123

Thanks, LGTM with small comment.

/wait

test/integration/tcp_tunneling_integration_test.cc

Signed-off-by: shikugawa <rei@tetrate.io>

mattklein123

Thank you!

comments addressed

mattklein123 · 2020-05-01T20:32:35Z

@Shikugawa please cleanup the PR description per the new template. Thank you!

/wait-any

…tream-max-stream-duration Signed-off-by: shikugawa <rei@tetrate.io>

Signed-off-by: shikugawa <rei@tetrate.io>

add max stream duration on upstream connection

89ba76c

Signed-off-by: shikugawa <rei@tetrate.io>

repokitteh-read-only bot added the api label Mar 26, 2020

delete unused sections

df7eb75

Signed-off-by: shikugawa <rei@tetrate.io>

mattklein123 self-assigned this Mar 26, 2020

mattklein123 requested changes Mar 26, 2020

View reviewed changes

include/envoy/upstream/upstream.h Outdated Show resolved Hide resolved

source/common/http/codec_client.h Outdated Show resolved Hide resolved

source/common/http/codec_client.h Outdated Show resolved Hide resolved

repokitteh-read-only bot added the waiting label Mar 26, 2020

repokitteh-read-only bot removed the api label Mar 27, 2020

fix

7449db5

Signed-off-by: shikugawa <rei@tetrate.io>

repokitteh-read-only bot removed the waiting label Mar 30, 2020

mattklein123 added the waiting label Mar 30, 2020

fix

9ca82f0

Signed-off-by: shikugawa <rei@tetrate.io>

repokitteh-read-only bot removed the waiting label Apr 2, 2020

resolve conflict

52ae433

Signed-off-by: shikugawa <rei@tetrate.io>

mattklein123 requested changes Apr 2, 2020

View reviewed changes

include/envoy/upstream/upstream.h Outdated Show resolved Hide resolved

test/integration/http2_integration_test.cc Outdated Show resolved Hide resolved

test/integration/http_integration.cc Show resolved Hide resolved

repokitteh-read-only bot added the waiting label Apr 2, 2020

fix

132ad71

Signed-off-by: shikugawa <rei@tetrate.io>

repokitteh-read-only bot removed the waiting label Apr 6, 2020

Merge branch 'master' into upstream-max-stream-duration

8d7b527

repokitteh-read-only bot added the api label Apr 6, 2020

mattklein123 requested changes Apr 6, 2020

View reviewed changes

test/common/router/router_test.cc Outdated Show resolved Hide resolved

test/integration/http_integration.h Outdated Show resolved Hide resolved

source/common/router/upstream_request.cc Outdated Show resolved Hide resolved

repokitteh-read-only bot added the waiting label Apr 6, 2020

Shikugawa added 2 commits April 7, 2020 02:15

fix

5e6eaa5

Signed-off-by: shikugawa <rei@tetrate.io>

fix

878d8f4

Signed-off-by: shikugawa <rei@tetrate.io>

repokitteh-read-only bot removed the waiting label Apr 7, 2020

mattklein123 added the waiting label Apr 7, 2020

add retry

f4ac4be

Signed-off-by: shikugawa <rei@tetrate.io>

Shikugawa added 2 commits April 29, 2020 14:00

Merge branch 'master' of https://github.com/envoyproxy/envoy into ups…

f65dd0b

…tream-max-stream-duration Signed-off-by: shikugawa <rei@tetrate.io>

connect termination

cf9dae4

Signed-off-by: shikugawa <rei@tetrate.io>

repokitteh-read-only bot removed the waiting label Apr 29, 2020

repokitteh-read-only bot added the waiting label Apr 29, 2020

Merge branch 'master' of https://github.com/envoyproxy/envoy into ups…

e68d9af

…tream-max-stream-duration Signed-off-by: shikugawa <rei@tetrate.io>

repokitteh-read-only bot removed the waiting label Apr 30, 2020

htuch reviewed Apr 30, 2020

View reviewed changes

repokitteh-read-only bot removed the api label Apr 30, 2020

Shikugawa added 2 commits April 30, 2020 16:41

Merge branch 'master' of https://github.com/envoyproxy/envoy into ups…

fb07faf

…tream-max-stream-duration Signed-off-by: shikugawa <rei@tetrate.io>

fix

382221e

Signed-off-by: shikugawa <rei@tetrate.io>

mattklein123 requested changes Apr 30, 2020

View reviewed changes

test/integration/tcp_tunneling_integration_test.cc Outdated Show resolved Hide resolved

repokitteh-read-only bot added the waiting label Apr 30, 2020

fix

dc0c318

Signed-off-by: shikugawa <rei@tetrate.io>

repokitteh-read-only bot added waiting and removed waiting labels May 1, 2020

fix

1e475e2

Signed-off-by: shikugawa <rei@tetrate.io>

repokitteh-read-only bot removed the waiting label May 1, 2020

mattklein123 previously approved these changes May 1, 2020

View reviewed changes

repokitteh-read-only bot added the waiting:any label May 1, 2020

Shikugawa added 2 commits May 4, 2020 05:07

Merge branch 'master' of https://github.com/envoyproxy/envoy into ups…

d75836c

…tream-max-stream-duration Signed-off-by: shikugawa <rei@tetrate.io>

fix

db8b989

Signed-off-by: shikugawa <rei@tetrate.io>

Shikugawa dismissed mattklein123’s stale review via db8b989 May 4, 2020 05:28

repokitteh-read-only bot added api and removed waiting:any labels May 4, 2020

mattklein123 approved these changes May 4, 2020

View reviewed changes

repokitteh-read-only bot removed the api label May 4, 2020

mattklein123 merged commit 6151a69 into envoyproxy:master May 4, 2020

Conversation

Shikugawa commented Mar 26, 2020 • edited by mattklein123 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

repokitteh-read-only bot commented Mar 26, 2020

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

htuch commented Mar 27, 2020

Uh oh!

Shikugawa commented Mar 30, 2020

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

htuch commented Apr 7, 2020

Uh oh!

mattklein123 commented Apr 29, 2020

Uh oh!

htuch left a comment

Choose a reason for hiding this comment

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

mattklein123 commented May 1, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Shikugawa commented Mar 26, 2020 •

edited by mattklein123

Loading