compressor: simplify logic

[rgs1]

This confused me the first time I read it, so make it simpler
for the next reader -- there's no need to handle not_compressed_.inc()
from the two different places. Delay it until encodeHeaders() and
do it once.

Signed-off-by: Raul Gutierrez Segales rgs@pinterest.com

[rgs1]

@mattklein123 @dio take 2 :-)

[rgs1]

Hmm, failed test passes locally for me:

//test/extensions/filters/http/cache:cache_filter_integration_test       PASSED in 4.3s

So guessing transient:

test/extensions/filters/http/cache/cache_filter_integration_test.cc:68
Value of: request->headers()
Expected: is a superset of headers:
':status', '200'
'date', 'Thu, 01 Jan 1970 01:00:01 GMT'
'cache-control', 'public,max-age=3600'
'content-length', '42'

  Actual: 16-byte object <E0-AB 68-01 00-00 00-00 B0-B3 68-01 00-00 00-00> (of type Envoy::Http::ResponseHeaderMap), where the following matchers don't match any elements:
matcher #1: is equal to ("date", "Thu, 01 Jan 1970 01:00:01 GMT")
Stack trace:
  0x84d18c: Envoy::Extensions::HttpFilters::Cache::CacheIntegrationTest_MissInsertHit_Test::TestBody()
  0x15f1028: testing::internal::HandleExceptionsInMethodIfSupported<>()
  0x15f0f55: testing::Test::Run()
  0x15f1e20: testing::TestInfo::Run()
... Google Test internal frames ...

cc: @toddmgreer

[dio]

/azp run envoy-linux

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[dio]

@rojkov could you help to take a look at this? Thanks!

[rojkov]

Thanks! This is simpler indeed.

[rojkov]

Looks good to me. Thanks!

[mattklein123]

Thanks!