test: avoid unnecessary copy triggering warning on Google import.#10428
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Mar 18, 2020
Merged
test: avoid unnecessary copy triggering warning on Google import.#10428mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
This occurs becaue of a new range loop "unnnecesary copy" warning in -Wall for latest Clang (-Wrange-loop-construct). This is not available in Clang 9. The related -Wrange-loop-analysis seems to have been disabled in Absl due to its lack of precision for small value types, see https://abseil.io/docs/cpp/platforms/compilerflags. Risk level: Low Testing: Build Signed-off-by: Harvey Tuch <htuch@google.com>
mattklein123
approved these changes
Mar 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This occurs becaue of a new range loop "unnnecesary copy" warning in -Wall for latest Clang
(-Wrange-loop-construct). This is not available in Clang 9.
The related -Wrange-loop-analysis seems to have been disabled in Absl due to its lack of
precision for small value types, see https://abseil.io/docs/cpp/platforms/compilerflags.
Risk level: Low
Testing: Build
Signed-off-by: Harvey Tuch htuch@google.com