jwt_authn: return a valid error message for require_any#10385
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Mar 18, 2020
Merged
jwt_authn: return a valid error message for require_any#10385mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Wayne Zhang <qiwzhang@google.com>
nareddyt
reviewed
Mar 16, 2020
nareddyt
approved these changes
Mar 16, 2020
lizan
approved these changes
Mar 17, 2020
Member
|
/retest |
|
🔨 rebuilding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wayne Zhang qiwzhang@google.com
Description:
In a RequireAny requirement, jwt_authn filter will iterate all these requirements one by one until one is successfully verified or all of them have been tested. If all of them failed, filter will return the last error. But a particular error is misleading, when a JWT is not indented for a provider, its error is either JwtMissed or JwtUnknownIssuer. The bug occurs when a provider returns a valid error but the last provider returns JwtMissed, the filter will return JwtMissed instead of the valid error.
Changes: remember the last valid error for RequireAny object, and return it for the failure case.
Risk Level: None
Testing: unit-tested
Docs Changes: None