router: add missing unit tests for x-envoy-attempt-count on upstream requests#10368
Merged
junr03 merged 3 commits intoenvoyproxy:masterfrom Mar 16, 2020
junr03:attempt-count-test
Merged
router: add missing unit tests for x-envoy-attempt-count on upstream requests#10368junr03 merged 3 commits intoenvoyproxy:masterfrom junr03:attempt-count-test
junr03 merged 3 commits intoenvoyproxy:masterfrom
junr03:attempt-count-test
Conversation
…requests Signed-off-by: Jose Nino <jnino@lyft.com>
alyssawilk
reviewed
Mar 13, 2020
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
Awesome test additions! A few thoughts below, mostly optional
test/common/router/router_test.cc
Outdated
|
|
||
| // Validate that x-envoy-attempt-count is added to request headers when option is true. | ||
| TEST_F(RouterTest, EnvoyAttemptCountInRequest) { | ||
| setIncludeAttemptCount(true); |
Contributor
There was a problem hiding this comment.
optional: do you want to name this to Request even though it doesn't reflect the config option until v4?
Member
Author
There was a problem hiding this comment.
I wanted to keep the name change in #10325. So I will update this or that other PR depending on merge order.
added 2 commits
March 13, 2020 10:21
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Member
Author
|
@alyssawilk updated! |
alyssawilk
approved these changes
Mar 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: adding missing unit test coverage.
Risk Level: low
Testing: added new tests
Fixes #10366