config: add config type to error logs during validation#10348
Merged
mattklein123 merged 4 commits intoenvoyproxy:masterfrom Mar 17, 2020
Merged
config: add config type to error logs during validation#10348mattklein123 merged 4 commits intoenvoyproxy:masterfrom
mattklein123 merged 4 commits intoenvoyproxy:masterfrom
Conversation
added 3 commits
March 11, 2020 16:53
Signed-off-by: Lisa Lu <lisalu@lyft.com>
Signed-off-by: Lisa Lu <lisalu@lyft.com>
Signed-off-by: Lisa Lu <lisalu@lyft.com>
Contributor
Author
|
/retest |
|
🔨 rebuilding |
zuercher
reviewed
Mar 13, 2020
| processFilter(filters[i], i, "http", filter_factories_, is_terminal); | ||
| Config::Utility::validateTerminalFilters(filters[i].name(), "http", is_terminal, | ||
| auto& factory = processFilter(filters[i], i, "http", filter_factories_, is_terminal); | ||
| Config::Utility::validateTerminalFilters(filters[i].name(), factory.name(), "http", is_terminal, |
Member
There was a problem hiding this comment.
I think it might be cleaner to just move the call to validateTerminalFilters inside processFilter. That way we don't have to hand back the factory reference and can get rid of the update of is_terminal by reference (that var can just be internal to processFilter). What do you think?
Contributor
Author
There was a problem hiding this comment.
I agree. I'll work on making that change.
Signed-off-by: Lisa Lu <lisalu@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Adds config type to error logs in validateTerminalFilters to make debugging easier, particularly now that the filter name does not determine the actual filter being configured.
Risk Level: Low
Testing: Updated existing unit tests.
Docs Changes: N/A
Release Notes: N/A