direct_response: use data source

[kyessenov]

Signed-off-by: Kuat Yessenov kuat@google.com

Description: switch to using a data source for a more usable API
Risk Level: low (just recently merged the API)
Testing: unit
Docs Changes: none
Release Notes:

cc @mergeconflict

[repokitteh-read-only]

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.

🐱

Caused by: #10342 was opened by kyessenov.

see: more, trace.

[mergeconflict]

nice :)

[htuch]

This is a breaking API change. You will need to add a new field for data source.

[mattklein123]

This was added in the last few days. No one is using it yet so IMO it's fine to change.

[kyessenov]

Weird coverage error once again:

All tests in the same test suite must use the same test fixture
class, so mixing TEST_F and TEST in the same test suite is
illegal.  In test suite UtilityTest,
test EnsureCreateSingletonsActuallyReturnsTheSameInstances is defined using TEST_F but
test ComputeHashedVersion is defined using TEST.  You probably
want to change the TEST to TEST_F or move it to another test
case.

[mattklein123]

Please merge master and it will fix that problem

[kyessenov]

Merged, still failing :( This time it looks legitimate, but I don't think I added any extra code paths.

[mattklein123]

@kyessenov hmm, dunno. I think the coverage build is pretty messed up right now and I wonder if the retries is causing strange results. Maybe we should remove that. cc @lizan @htuch

/wait

[kyessenov]

/retest

[repokitteh-read-only]

🔨 rebuilding ci/circleci: coverage (failed build)

🐱

Caused by: a #10342 (comment) was created by @kyessenov.

see: more, trace.

[kyessenov]

PTAL. Coverage test de-flaked.

[htuch]

LGTM, thanks!