http: Add max stream duration#10314
Merged
mattklein123 merged 18 commits intoenvoyproxy:masterfrom Mar 19, 2020
Merged
Conversation
Signed-off-by: shikugawa <rei@tetrate.io>
htuch
reviewed
Mar 10, 2020
mattklein123
requested changes
Mar 10, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks for working on this. Some high level API/doc comments to get started. Thank you!
/wait
…-max-stream-timeout Signed-off-by: shikugawa <rei@tetrate.io>
Signed-off-by: shikugawa <rei@tetrate.io>
…-max-stream-timeout Signed-off-by: shikugawa <rei@tetrate.io>
mattklein123
requested changes
Mar 12, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks generally LGTM, flushing out some comments.
/wait
…-max-stream-timeout Signed-off-by: shikugawa <rei@tetrate.io>
…-max-stream-timeout Signed-off-by: shikugawa <rei@tetrate.io>
Signed-off-by: shikugawa <rei@tetrate.io>
mattklein123
requested changes
Mar 13, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks LGTM other than a few small comments.
/wait
…-max-stream-timeout Signed-off-by: shikugawa <rei@tetrate.io>
Signed-off-by: shikugawa <rei@tetrate.io>
mattklein123
requested changes
Mar 16, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks looks great modulo some doc comments. Thank you!
/wait
mattklein123
requested changes
Mar 17, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM w/ a test name/comment nit. Sorry I didn't comment on this before.
/wait
Signed-off-by: shikugawa <rei@tetrate.io>
Signed-off-by: shikugawa <rei@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shikugawa rei@tetrate.io
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: Add max stream duration to specify alive time of the stream. related with #10274
Risk Level: Low
Testing: Unit, Integration
Docs Changes: Required
Release Notes: Required
[Optional Fixes #Issue]
[Optional Deprecated:]