admin: Add /reopen_logs admin handler#10286
Merged
mattklein123 merged 15 commits intoenvoyproxy:masterfrom Mar 18, 2020
Merged
Conversation
Signed-off-by: Oleg Guba <oleg@dropbox.com>
Signed-off-by: Oleg Guba <oleg@dropbox.com>
Member
|
At a high level LGTM, thanks. Obviously needs release notes, docs, etc. Thank you! /wait |
Signed-off-by: Oleg Guba <oleg@dropbox.com>
Signed-off-by: Oleg Guba <oleg@dropbox.com>
Signed-off-by: Oleg Guba <oleg@dropbox.com>
Signed-off-by: Oleg Guba <oleg@dropbox.com>
Signed-off-by: Oleg Guba <oleg@dropbox.com>
Contributor
Author
|
/wait |
dio
reviewed
Mar 9, 2020
Signed-off-by: Oleg Guba <oleg@dropbox.com>
Contributor
Author
|
/wait |
Signed-off-by: Oleg Guba <oleg@dropbox.com>
Member
|
@veshij as noted by Matt, could you add release notes (docs/root/intro/version_history.rst) and relevant docs? Thank you! |
Signed-off-by: Oleg Guba <oleg@dropbox.com>
dio
changed the title
dio
previously approved these changes
Mar 16, 2020
mattklein123
requested changes
Mar 17, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM with small comment, thanks.
/wait
Signed-off-by: Oleg Guba <oleg@dropbox.com>
Contributor
Author
|
/wait |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds
/reopen_logsadmin handler to control log rotation.Risk Level: Low
Testing: Unit test
Docs Changes: Added
Release Notes: Added
Fixes #10266
Signed-off-by: Oleg Guba oleg@dropbox.com