Skip to content

common: add big-endian support to Ip6ntohl and Ip6htonl #10250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattklein123 merged 1 commit into from
Mar 4, 2020
Merged

common: add big-endian support to Ip6ntohl and Ip6htonl #10250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions source/common/network/utility.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,17 +424,19 @@ bool Utility::portInRangeList(const Address::Instance& address, const std::list<
}

absl::uint128 Utility::Ip6ntohl(const absl::uint128& address) {
// TODO(ccaraman): Support Ip6ntohl for big-endian.
static_assert(ABSL_IS_LITTLE_ENDIAN,
"Machines using big-endian byte order is not supported for IPv6.");
#ifdef ABSL_IS_LITTLE_ENDIAN
return flipOrder(address);
#else
return address;
#endif
}

absl::uint128 Utility::Ip6htonl(const absl::uint128& address) {
// TODO(ccaraman): Support Ip6ntohl for big-endian.
static_assert(ABSL_IS_LITTLE_ENDIAN,
"Machines using big-endian byte order is not supported for IPv6.");
#ifdef ABSL_IS_LITTLE_ENDIAN
return flipOrder(address);
#else
return address;
#endif
}

absl::uint128 Utility::flipOrder(const absl::uint128& input) {
Expand Down