[fuzz] split out the uber filter test class#10249
Merged
mattklein123 merged 4 commits intoenvoyproxy:masterfrom Mar 15, 2020
Merged
[fuzz] split out the uber filter test class#10249mattklein123 merged 4 commits intoenvoyproxy:masterfrom
mattklein123 merged 4 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
nareddyt
previously approved these changes
Mar 4, 2020
zuercher
previously approved these changes
Mar 5, 2020
Member
zuercher
left a comment
zuercher
left a comment
There was a problem hiding this comment.
Nice! Looks besides some include pedantry. TIOLI.
| @@ -1,153 +1,20 @@ | |||
| #include <chrono> | |||
| #include <memory> | |||
Member
There was a problem hiding this comment.
nit: I think you can get rid of these two as well.
| @@ -0,0 +1,150 @@ | |||
| #include <chrono> | |||
Member
There was a problem hiding this comment.
nit: don't think this is being used either
Signed-off-by: Asra Ali <asraa@google.com>
Contributor
Author
|
Sorry this feel off the radar last week -- thank you! Merged master as well |
zuercher
approved these changes
Mar 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor to split out the uber filter test class. Projects depending on Envoy can use the
fuzzmethod of the class with anHttpFilterandHttpDatainput.@nareddyt (You might need to do something similar to the post-processor mutation I have to specify the type of the Any to be one of your 4 filters, this helps guide the protobuf mutator).
Testing: no-op
Risk: Low
Signed-off-by: Asra Ali asraa@google.com