Skip to content

Enable v8 build on Arm64 server #10224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lizan merged 1 commit into from
Mar 18, 2020
Merged

Enable v8 build on Arm64 server #10224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions bazel/external/wee8.genrule_cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@

set -e

# This works only on Linux-{x86_64,s390x} and macOS-x86_64.
# This works only on Linux-{x86_64,s390x,aarch64} and macOS-x86_64.
case "$$(uname -s)-$$(uname -m)" in
Linux-x86_64|Linux-s390x|Darwin-x86_64)
Linux-x86_64|Linux-s390x|Linux-aarch64|Darwin-x86_64)
;;
*)
echo "ERROR: wee8 is currently supported only on Linux-{x86_64,s390x} and macOS-x86_64." >&2
echo "ERROR: wee8 is currently supported only on Linux-{x86_64,s390x,aarch64} and macOS-x86_64." >&2
exit 1
esac

Expand Down Expand Up @@ -73,6 +73,10 @@ WEE8_BUILD_ARGS+=" v8_use_external_startup_data=false"
# Disable read-only heap, since it's leaky and HEAPCHECK complains about it.
# TODO(PiotrSikora): remove when fixed upstream.
WEE8_BUILD_ARGS+=" v8_enable_shared_ro_heap=false"
# Support Arm64
if [[ `uname -m` == "aarch64" ]]; then
WEE8_BUILD_ARGS+=" target_cpu=\"arm64\""
fi

# Build wee8.
if [[ "$$(uname -s)" == "Darwin" ]]; then
Expand All @@ -82,6 +86,7 @@ elif [[ "$$(uname -s)-$$(uname -m)" == "Linux-x86_64" ]]; then
gn=buildtools/linux64/gn
ninja=third_party/depot_tools/ninja
else
# Using system default ninja & gn tools
gn=$$(command -v gn)
ninja=$$(command -v ninja)
fi
Expand Down