Merged
Conversation
Signed-off-by: Yuchen Dai <silentdai@gmail.com> http://www.wangafu.net/~nickm/libevent-book/Ref3_eventloop.html Pseudocode while (any events are registered with the loop, or EVLOOP_NO_EXIT_ON_EMPTY was set) { if (EVLOOP_NONBLOCK was set, or any events are already active) If any registered events have triggered, mark them active. else Wait until at least one event has triggered, and mark it active. ... }
Member
|
Thanks for the contribution, but from an interface perspective we are mostly trying to the hide the libevent details and I think the existing text is probably fine? I'm not sure it's really worth updating. |
Contributor
Author
|
Our code base is relying on the described behavior. See below. |
mattklein123
approved these changes
Mar 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yuchen Dai silentdai@gmail.com
Description:
See http://www.wangafu.net/~nickm/libevent-book/Ref3_eventloop.html
Pseudocode
while (any events are registered with the loop,
or EVLOOP_NO_EXIT_ON_EMPTY was set) {
...
}
Risk Level: LOW
Testing:
Docs Changes:
Release Notes: