test: use semantic network filter names#10122
test: use semantic network filter names#10122mattklein123 merged 4 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Kuat Yessenov <kuat@google.com>
|
I have another PR finishing the rename for all extensions. I think it's a good idea to keep it separate to make the review easier. |
zuercher
left a comment
There was a problem hiding this comment.
Looks good. Are there tests around somewhere that continue to test the old paths?
|
Yeah, the |
|
I'm worried that we'll eventually excise all those and end up with an untested path without realizing it, and that it might stop working before the point where we intentionally delete it. |
|
I share the concern. Given that the typed config type URL takes precedence, we can only exercise the non-typed lookup for filters with no config, really. Router is one of them and we should keep it that way. The code path for all extension lookups is the same, so until we merge #10130 , we're safe from the risk. I should add a test case to #10130 to make sure we keep the empty-config lookup by name functional. |
|
Hi! Can we merge this or is there something else that needs to be done? |
Description: exercise semantic names for network filter extensions. Follow up to #10071.
Risk Level: low. there is a change to properly support type URL inside typed structs (stripping
type.googleapis.com)Testing: unit tests
Docs Changes: none
Release Notes:
/assign @zuercher